Conversation
Updated redis to 1.0.2 with API compatibility fixes and clippy lint fixes.
Clippy 1.92 now detects struct field assignments in derive macro tests as unused. This is expected behavior since fields marked with #[source], #[backtrace], #[provide] are consumed by the derive macro. Following thiserror's approach of using allow attributes for macro-generated code patterns in tests.
Instead of hardcoding Rust version in CI, now MSRV is extracted from Cargo.toml rust-version field. This ensures consistency between local development and CI. Changes: - Added msrv job to extract version from Cargo.toml - check job now depends on msrv and uses its output - Updated cache key to use resolved toolchain version
This was referenced Dec 26, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Added custom funding links for cryptocurrency donations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo updateErrorKind::BusyLoadingError->ServerErrorKind::BusyLoading)unused_assignmentsto derive test allow list (clippy 1.92 compatibility)Test plan
cargo test --all-features)cargo clippy --all-features --all-targets -- -D warnings)cargo +nightly fmt)